Primitive : Use tbb parallel_reduce to accelerate bounds compute #1336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proberts-cinesite
force-pushed
the
PrimitiveBoundUseParallelReduce
branch
from
a4bd9d6 to
d9d089f
Compare
johnhaddon
requested changes
Feb 17, 2023
Member
johnhaddon
left a comment
johnhaddon
left a comment
There was a problem hiding this comment.
Thanks Paul, this provides a nice speedup in my tests. Do you fancy giving the same treatment to the PointsPrimitive::bound() override?
src/IECoreScene/Primitive.cpp
Outdated
Comment on lines
90
to
92
| for( const V3f | ||
| * it = range.begin(), | ||
| *const itEnd = range.end(); it != itEnd; ++it ) |
Member
There was a problem hiding this comment.
for( const V3f &point : range )
Now that range-for exists, I automatically assume that a for loop with pointer arithmetic in will contain some custom logic rather than just be visiting every element in the range.
Contributor
Author
|
I have given the same treatment to the |
johnhaddon
force-pushed
the
PrimitiveBoundUseParallelReduce
branch
from
ffaffa8 to
0953512
Compare
Member
|
Thanks Paul - I've squashed in the fixup and fixed the Changes.md conflict. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multithread default bounds computation using
tbb::parallel_reduce.Checklist